Skip to content

Run make generated-files and make generate-catalog #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

creydr
Copy link
Member

@creydr creydr commented Feb 14, 2025

As we have some issues ATM in the catalog (#3385 (comment)) running make generated-files and make generate-catalog manually.

@openshift-ci openshift-ci bot requested a review from rhuss February 14, 2025 09:58
@creydr creydr mentioned this pull request Feb 14, 2025
@creydr
Copy link
Member Author

creydr commented Feb 17, 2025

/retest-required

@creydr creydr mentioned this pull request Feb 17, 2025
@creydr
Copy link
Member Author

creydr commented Feb 17, 2025

e2e test fail due to

13:19:16.958 ERROR:   🚨 Error (code: 1) occurred at /go/src/github.com/openshift-knative/serverless-operator/hack/lib/testselect.bash:10, with command: go install github.com/openshift-knative/hack/cmd/testselect

which would be fixed by #3388 (but #3388 requires this PR (see #3388 (comment)) 🐔 🥚 ). I'll update this PR to include the testselect changes...

@dsimansk
Copy link
Contributor

/approve
/lgtm

@dsimansk
Copy link
Contributor

@creydr did it work on the original PR with go run?

go: github.com/openshift-knative/hack/cmd/testselect@latest: cannot query module due to -mod=vendor
09:48:57.766 ERROR:   🚨 Error (code: 1) occurred at /go/src/github.com/openshift-knative/serverless-operator/hack/lib/testselect.bash:17, with command: go run github.com/openshift-knative/hack/cmd/testselect@latest --testsuites="${rootdir}/test/testsuites.yaml" --clonerefs="${ARTIFACT_DIR}/clonerefs.json" --output="${ARTIFACT_DIR}/tests.txt"

@creydr
Copy link
Member Author

creydr commented Feb 17, 2025

@creydr did it work on the original PR with go run?

go: github.com/openshift-knative/hack/cmd/testselect@latest: cannot query module due to -mod=vendor
09:48:57.766 ERROR:   🚨 Error (code: 1) occurred at /go/src/github.com/openshift-knative/serverless-operator/hack/lib/testselect.bash:17, with command: go run github.com/openshift-knative/hack/cmd/testselect@latest --testsuites="${rootdir}/test/testsuites.yaml" --clonerefs="${ARTIFACT_DIR}/clonerefs.json" --output="${ARTIFACT_DIR}/tests.txt"

I didn't get so far in the other PR

@dsimansk
Copy link
Contributor

@creydr ahh, I see. Anyway, thanks for looking into it!

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ab8cf34 and 2 for PR HEAD 95f52d5 in total

@openshift-ci openshift-ci bot removed the lgtm label Feb 17, 2025
@dsimansk
Copy link
Contributor

/retest

@dsimansk
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 17, 2025
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor

/override ?

Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • Konflux kflux-prd-rh02 / serverless-bundle-136-on-pull-request
  • Update deps
  • ci/prow/417-aws-ovn-images
  • ci/prow/417-azure-images
  • ci/prow/417-gcp-images
  • ci/prow/417-hypershift-images
  • ci/prow/417-images
  • ci/prow/417-operator-e2e
  • ci/prow/417-osd-images
  • ci/prow/417-single-node-images
  • ci/prow/417-test-upgrade
  • ci/prow/417-upstream-e2e
  • ci/prow/417-upstream-e2e-kafka
  • ci/prow/417-vsphere-images
  • ci/prow/ocp4.17-lp-rosa-classic-images
  • ci/prow/ocp4.18-lp-interop-images
  • code/snyk (Hybrid Platforms - OpenShift Serverless)
  • license/snyk (Hybrid Platforms - OpenShift Serverless)
  • pull-ci-openshift-knative-serverless-operator-main-417-aws-ovn-images
  • pull-ci-openshift-knative-serverless-operator-main-417-azure-images
  • pull-ci-openshift-knative-serverless-operator-main-417-gcp-images
  • pull-ci-openshift-knative-serverless-operator-main-417-hypershift-images
  • pull-ci-openshift-knative-serverless-operator-main-417-images
  • pull-ci-openshift-knative-serverless-operator-main-417-operator-e2e
  • pull-ci-openshift-knative-serverless-operator-main-417-osd-images
  • pull-ci-openshift-knative-serverless-operator-main-417-single-node-images
  • pull-ci-openshift-knative-serverless-operator-main-417-test-upgrade
  • pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e
  • pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e-kafka
  • pull-ci-openshift-knative-serverless-operator-main-417-vsphere-images
  • pull-ci-openshift-knative-serverless-operator-main-ocp4.17-lp-rosa-classic-images
  • pull-ci-openshift-knative-serverless-operator-main-ocp4.18-lp-interop-images
  • security/snyk (Hybrid Platforms - OpenShift Serverless)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

Failed on source image build, infra issue rather than anything related to PR changes.

/override "Konflux kflux-prd-rh02 / serverless-bundle-136-on-pull-request"

Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@dsimansk: Overrode contexts on behalf of dsimansk: Konflux kflux-prd-rh02 / serverless-bundle-136-on-pull-request

In response to this:

Failed on source image build, infra issue rather than anything related to PR changes.

/override "Konflux kflux-prd-rh02 / serverless-bundle-136-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 52ff4c8 into openshift-knative:main Feb 17, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants