-
Notifications
You must be signed in to change notification settings - Fork 70
Run make generated-files
and make generate-catalog
#3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run make generated-files
and make generate-catalog
#3387
Conversation
/retest-required |
e2e test fail due to
which would be fixed by #3388 (but #3388 requires this PR (see #3388 (comment)) 🐔 🥚 ). I'll update this PR to include the testselect changes... |
/approve |
@creydr did it work on the original PR with
|
I didn't get so far in the other PR |
@creydr ahh, I see. Anyway, thanks for looking into it! |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ? |
@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Failed on source image build, infra issue rather than anything related to PR changes. /override "Konflux kflux-prd-rh02 / serverless-bundle-136-on-pull-request" |
@dsimansk: Overrode contexts on behalf of dsimansk: Konflux kflux-prd-rh02 / serverless-bundle-136-on-pull-request In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
52ff4c8
into
openshift-knative:main
As we have some issues ATM in the catalog (#3385 (comment)) running
make generated-files
andmake generate-catalog
manually.