Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Nov 6, 2025

Update test selection to check all code locations with full paths. A test is excluded only if all full-path locations are external (vendored or from k8s.io/kubernetes/test). Tests with at least one local code location are included, allowing local tests to use vendored helper functions.

Update test selection to check all code locations with full paths.
A test is excluded only if all full-path locations are external
(vendored or from k8s.io/kubernetes/test). Tests with at least
one local code location are included, allowing local tests to
use vendored helper functions.
@openshift-ci openshift-ci bot requested review from jupierce and smg247 November 6, 2025 18:39
@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2025
@stbenjam stbenjam changed the title refactor(tests): improve ModuleTestsOnly filtering logic OCPBUGS-64594: refactor(tests): improve ModuleTestsOnly filtering logic Nov 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 6, 2025
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-64594, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update test selection to check all code locations with full paths. A test is excluded only if all full-path locations are external (vendored or from k8s.io/kubernetes/test). Tests with at least one local code location are included, allowing local tests to use vendored helper functions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member Author

stbenjam commented Nov 6, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants