Add Mapped field to Image struct

[dinhxuanvu]

The Mapped key will hold information regarding mapped images that can be used later for openshift-tests images cmd.

See #openshift/kubernetes#2447

[openshift-ci]

Hi @dinhxuanvu. Thanks for your PR.

I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dinhxuanvu]

Related to openshift/kubernetes#2447
@bertinatto @smg247 PTAL

[bertinatto]

In theory external binaries could return values with deeply-nested images, but I believe it's fine because we're only interested in the first level. The other options is to make it flat, but I can go either way.

@smg247 @stbenjam thoughts?

[dinhxuanvu]

Just to elaborate on what Fabio said. If the deeply-nested struct is not acceptable, we can do flat struct like this:

type Image struct {
	Index    int         `json:"index"`
	Registry string      `json:"registry"`
	Name     string      `json:"name"`
	Version  string      `json:"version"`
	Mapped   MappedImage `json:"mapped,omitempty"`
}

type MappedImage struct {
	Index    int    `json:"index"`
	Registry string `json:"registry"`
	Name     string `json:"name"`
	Version  string `json:"version"`
}

[stbenjam]

/ok-to-test

[stbenjam]

The only thing I'd suggest here is adding a comment about why one should populate this field.

[dinhxuanvu]

Done

[stbenjam]

/retest

[stbenjam]

You dropped the field itself :)

[dinhxuanvu]

Ugh, git did me dirty... Fixed.

[stbenjam]

/lgtm

[stbenjam]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment