Support using decimal as span literals #4717
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanchun Shen <[email protected]>
yuancu
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar and
ykmr1224
as code owners
LantaoJin
reviewed
Nov 3, 2025
| } | ||
|
|
||
| @Test | ||
| public void testBinWithDecimalSpan() throws IOException { |
There was a problem hiding this comment.
is span(@timestamp, 0.5d) supported with this PR? please add an IT for that
There was a problem hiding this comment.
Please note that the following items are not in scope as they were not supported:
- decimal + time unit. E.g. | timechart span=0.95d
- decimal for span used in stats. E.g. | stats span(value, 9.5)
What exception will be thrown in above PPLs, please add IT or UT for them.
There was a problem hiding this comment.
-
Added a unit test for the error in the first use case
-
Restore support to the second case:
- decimal for span used in stats. E.g. | stats span(value, 9.5)
yuancu
changed the title
Signed-off-by: Yuanchun Shen <[email protected]>
Signed-off-by: Yuanchun Shen <[email protected]>
Signed-off-by: Yuanchun Shen <[email protected]>
LantaoJin
reviewed
Nov 4, 2025
| assertThrows( | ||
| SyntaxCheckException.class, | ||
| () -> plan("source=t | stats count by span(@timestamp, 2.5y)")); | ||
| assertTrue(t2.getMessage().contains("[y] is not a valid term at this part of the query")); |
There was a problem hiding this comment.
"[y] is not a valid term" is a confusing error message since user can use span(@timestamp, 1y)
There was a problem hiding this comment.
Fixed. The error message becomes Span length [2.5y] is invalid: floating-point time intervals are not supported.
Signed-off-by: Yuanchun Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restores support for decimal in span literals for bin commad.
E.g. It makes the following queries possible
source=events_null | bin cpu_usage span=7.5 | stats count() by cpu_usage| stats span(value, 9.5)Please note that the following items are not in scope as they were not supported:
| timechart span=0.95dRelated Issues
Resolves #4631
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.