Enhance doc and error message handling for bins on time-related fields
#4713
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahkcs
force-pushed
the
bins_time
branch
2 times, most recently
from
8e60c28 to
a8cafb8
Compare
…d fields with pushdown disabled Signed-off-by: Kai Huang <[email protected]>
ahkcs
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
Signed-off-by: Kai Huang <[email protected]>
ahkcs
changed the title
bins on time-related fieldsbins on time-related fields
Signed-off-by: Kai Huang <[email protected]>
|
unit tests in CI seems flaky |
noCharger
approved these changes
Nov 6, 2025
|
|
||
| // Create validated binnable field (validates that field is numeric or time-based) | ||
| // Note: bins parameter works with both numeric and time-based fields | ||
| // Note: bins parameter on time-based fields requires pushdown to be enabled |
There was a problem hiding this comment.
Nit: Describe the default behavior and the configuration that controls pushdown.
qianheng-aws
reviewed
Nov 6, 2025
| "Expected clear error message about bins parameter not supported on timestamp fields when " | ||
| + "pushdown is disabled, but got: " | ||
| + errorMessage, | ||
| errorMessage.contains( |
There was a problem hiding this comment.
Although we enabled push down, we still don't support query like source=events_null | bin @timestamp bins=3.
Shall we call out that it's also required to be used as the aggregation bucket field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR adds clear error handling and documentation for the known limitation that the bins parameter on timestamp fields requires pushdown to be enabled.
Related Issues
bincommand fails with param bins on time-related fields #4578