add plugins.removeList to allow remove plugins #526
Conversation
ruanyl
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
resolved opensearch-project#383 Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
feature-plugin-remove-list
branch
from
38f9da3 to
704bc9d
Compare
There was a problem hiding this comment.
Hi @ruanyl ,
Please make sure you update the changelog and versions.
And address the few comments I posted. Thanks 😄
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Thank you for the guidance, this is the first time I make change to this repo, I followed some other PRs on how to bump the version and update the change logs, let me know if I missed anything :D |
Signed-off-by: Yulong Ruan <[email protected]>
|
Pending #594 to be merged before updating this PR. No action required I will take care. Thanks. |
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
|
Thanks @ruanyl , please make a backport to 1.x version. |
|
@peterzhuamazon |
Helm charts due to its version scheme and formats, currently does not support auto backports 😄 |
* add plugins.removeList to allow remove plugins resolved opensearch-project#383 Signed-off-by: Yulong Ruan <[email protected]> * check if opensearch plugin exists before removing Signed-off-by: Yulong Ruan <[email protected]> * bump version and add changelog Signed-off-by: Yulong Ruan <[email protected]> * update changelog Signed-off-by: Yulong Ruan <[email protected]> * Update version Signed-off-by: Peter Zhu <[email protected]> * Update charts version Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Description
During the development phase, it's common to deploy a cluster with plugins that are still in progress. To facilitate the installation of these plugins, the current approach involves removing existing plugins and then installing the development versions. This process often requires manual intervention.
This pull request addresses this issue by introducing the
removeListto the Helm charts. With this enhancement, we can manage the installation and removal of plugins with eliminating the need for manual intervention.Addresses the issue described in #383, where user encountered challenges related to plugin removal.
Issues Resolved
resolved #383
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.