Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opensearch.yml configMap Read-only file system error #516

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Feb 7, 2024

Description

Coming from an open PR #504, that removes opensearch.yml due to configMap Read-only file system error (as starting 2.12.0 OpenSearch security plugin need RW access to opensearch.yml when passed OPENSEARCH_INITIAL_ADMIN_PASSWORD, for more details ref: opensearch-project/security#3624).

This PR will have a fix to continue use the .Values.config and declare the opensearch.yml and does not throw configMap Read-only file system error.

With this the user can either use the default opensearch.yml or pass the opensearch.yml via .Values.config.

Issues Resolved

#224
part of: opensearch-project/security#3624, opensearch-project/security#3711

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with this, but pulled locally and it works, so approving this as alternative if that's the better direction.

@prudhvigodithi
Copy link
Member Author

Adding @TheAlgo @smlx @peterzhuamazon , to please have a look.

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with @derek-ho along with admin credentials change (#503). It seems to be working locally. Approving this.

@prudhvigodithi
Copy link
Member Author

Thanks @derek-ho and @DarshitChanpura.

@prudhvigodithi prudhvigodithi merged commit a1c5b8f into opensearch-project:main Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants