Allow passing in custom pod anti-affinity, as well as pod affinity #495
Conversation
emmahsax
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
|
I'm not sure if I'm supposed to manually update the |
|
Hey @emmahsax, apologies for the delay, yes the changelog needs to be updated? Here is the sample merged Pull request https://github.com/opensearch-project/helm-charts/pull/482/files. |
Updating URL Allow custom anti-affinity Add a custom option Haha oops Empty commit Try to version bump to a custom version Maybe this will work Use lower chart Try this Now that I know all tests pass, try to go back to 0.0.1 Put all of these back Signed-off-by: Emma Sax <[email protected]>
Signed-off-by: Divya Madala <[email protected]> Signed-off-by: Emma Sax <[email protected]>
Signed-off-by: Emma Sax <[email protected]>
Signed-off-by: Emma Sax <[email protected]>
|
@prudhvigodithi Thanks. The Changelog is updated. I also synced my branch with the latest from |
|
Thanks @emmahsax, Since this is a not the OpenSerach version upgrade can you please change this to |
Signed-off-by: Emma Sax <[email protected]>
Signed-off-by: Emma Sax <[email protected]>
|
@prudhvigodithi Thanks! Complete. |
|
LGTM. @TheAlgo @peterzhuamazon can you please check? |
Description
This change allows people to pass in both pod affinity as well as custom pod anti-affinity (which will ignore the default
hardandsoftanti-affinity currently present in this helm chart).To use the
customAntiAffinity,antiAffinitymust be set tocustom, otherwise the defaultsoftaffinity will be used. IfantiAffinityis set tocustom, but nothing is specified incustomAntiAffinity, then{}will be used for anti-affinity.Issues Resolved
This change will resolve #397.
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.