fix alert acknowledge not refreshing page #1326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KashKondaka <[email protected]>
KashKondaka
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
getsaurabh02,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
AWSHurneyt
approved these changes
Nov 13, 2025
Collaborator
|
Approved assuming checks pass. |
amsiglan
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After acknowledging an alert in the flyout, it doesn't update status of that alert as acknowledged unless you renter flyout or reload the page. We updated helpers.js so function returns a single awaitable promise. We then updated the alerts dashboard to wait for acknowledgeAlerts() to complete before getting alerts. This essentially fixed the problem, but there is now aredundant Promise.all() wrapper that we remove from Dashboard.js since our helpers.js change does that.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.