PPL Alerting with Feature Flag #1311

KashKondaka · 2025-11-07T20:24:20Z

Description

PPL Alerting changes

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ject#1295) (cherry picked from commit a232821) Signed-off-by: opensearch-ci <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…opensearch-project#1297) (cherry picked from commit 147e2e7) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Revert "fix mustache format notif message" This reverts commit 862d635. update tests Signed-off-by: KashKondaka <[email protected]>

Signed-off-by: KashKondaka <[email protected]>

amsiglan · 2025-11-07T21:34:44Z

public/services/services.ts

+  if (alertingDashboardsCap?.pplV2 === true || alertingCap?.pplV2 === true) {
+    return true;
+  }
+  return true;


keep this false

amsiglan · 2025-11-07T21:36:02Z

public/services/services.ts

+    return true;
+  }
+  const alertingDashboardsCap = capabilities.alertingDashboards;
+  const alertingCap = capabilities.alerting;


remove this one and also simply return !!capabilities.alertingDashboards?.pplV2

amsiglan · 2025-11-07T21:37:39Z

public/services/services.ts

+  if (!isPplV2Enabled()) {
+    return false;
+  }


Remove this since this check is not ppl alerting and should exist regardless

Signed-off-by: KashKondaka <[email protected]>

amsiglan · 2025-11-07T23:46:22Z

server/plugin.js

    destinations(services, router, dataSourceEnabled);
    opensearch(services, router, dataSourceEnabled);
    monitors(services, router, dataSourceEnabled);
+    pplAlertingMonitors(services, router, dataSourceEnabled);


gate this and remove the per api gating

amsiglan · 2025-11-07T23:53:29Z

server/routes/monitors.js

    monitorService.getMonitors
  );

+  router.get(


Why do we have this?

shouldn't have it removed

amsiglan · 2025-11-07T23:55:37Z

public/types.ts

+export type { ExplorePluginSetup, ExplorePluginStart } from '../../../src/plugins/explore/public';
+// @ts-ignore
+export type { QueryWithQueryAsString } from '../../../src/plugins/explore/public';


We shouldn't be exporting these from this plugin?

These are needed for alert flyout in discover.

Signed-off-by: KashKondaka <[email protected]>

amsiglan · 2025-11-08T00:14:17Z

public/plugin.tsx

+      // mount: async (params) => {
+      //   const { renderApp } = await import('./app');
+      //   const [coreStart] = await core.getStartServices();
+      //   return renderApp(coreStart, params);
+      // },


other places too

ack removed

amsiglan · 2025-11-08T00:16:21Z

public/plugin.tsx

        order: 9070,
        category: DEFAULT_APP_CATEGORIES.detect,
-        updater$: this.appStateUpdater,
+        updater$: this.appStateUpdater$ as any,


why did we make this change?

was getting a type error because the navigation API expects an Observable, not the BehaviorSubject instance itself. BehaviorSubject implements the observable interface, but its public type also exposes .next() and .value which doesn't match watch the registry expects

Signed-off-by: KashKondaka <[email protected]>

amsiglan · 2025-11-08T00:17:52Z

public/plugin.tsx


-  public start(core: CoreStart, { visAugmenter, embeddable, data, navigation, contentManagement, assistantDashboards }: AlertingStartDeps): AlertingStart {
+  public start(core: CoreStart, { visAugmenter, embeddable, data, navigation, contentManagement, assistantDashboards, explore }: AlertingStartDeps): AlertingStart {
+    navigateToAppRef = core.application.navigateToApp;


where are we using this? and why do we need to create a variable for this?

this was old code for transporting query to ppl alerting. removing it

amsiglan · 2025-11-08T00:19:51Z

public/utils/ppl_alerting_support.ts

+  return { status: 'unknown' };
+};
+
+export const ensurePplSupport = (


what is this used for?

not actually being used, will remove

amsiglan · 2025-11-08T00:25:27Z

public/services/services.ts

+  if (!isPplAlertingEnabled()) {
+    return false;
+  }


Let's remove this since updated ux should not be gated on ppl alerting

When I remove this it looks like updated ux overwrites ppl flag

found error, fixed

amsiglan · 2025-11-08T00:36:19Z

public/pages/CreateMonitor/components/CustomSteps/CustomSteps.js

Can you change all new files to be ts(x)?

will address in next pr

Signed-off-by: KashKondaka <[email protected]>

opensearch-trigger-bot bot and others added 4 commits October 7, 2025 13:03

add explore as optional plugin

5cb04ef

Revert "fix mustache format notif message" This reverts commit 862d635. update tests Signed-off-by: KashKondaka <[email protected]>

add feature flag

310d837

Signed-off-by: KashKondaka <[email protected]>

KashKondaka requested review from AWSHurneyt, amsiglan, bowenlan-amzn, eirsep, getsaurabh02, lezzago, praveensameneni, rishabhmaurya, riysaxen-amzn and sbcd90 as code owners November 7, 2025 20:24

amsiglan reviewed Nov 7, 2025

View reviewed changes

KashKondaka added 4 commits November 7, 2025 14:22

refactor ppl alerting and alerting apis

d83a0aa

Signed-off-by: KashKondaka <[email protected]>

back to 3.3 and remove console.log debugs

27558d0

Signed-off-by: KashKondaka <[email protected]>

address comments

80dd81d

Signed-off-by: KashKondaka <[email protected]>

hide create monitor button when feature flag is false

bce713c

Signed-off-by: KashKondaka <[email protected]>

amsiglan reviewed Nov 7, 2025

View reviewed changes

prevent routes being registered when ppl false

5f1d591

Signed-off-by: KashKondaka <[email protected]>

amsiglan reviewed Nov 8, 2025

View reviewed changes

route registration behind feature flag

86705b6

Signed-off-by: KashKondaka <[email protected]>

amsiglan reviewed Nov 8, 2025

View reviewed changes

KashKondaka added 10 commits November 7, 2025 16:56

c

589d37b

Signed-off-by: KashKondaka <[email protected]>

fix gating for flag

820918b

Signed-off-by: KashKondaka <[email protected]>

address comments

dec538b

Signed-off-by: KashKondaka <[email protected]>

address comments

3ffd68a

Signed-off-by: KashKondaka <[email protected]>

c

41c4051

Signed-off-by: KashKondaka <[email protected]>

c

6335c72

Signed-off-by: KashKondaka <[email protected]>

c

c0d2768

Signed-off-by: KashKondaka <[email protected]>

c

7d5d04d

Signed-off-by: KashKondaka <[email protected]>

remove logs and fix v1 api call

f161c83

Signed-off-by: KashKondaka <[email protected]>

update unit tests

2634137

Signed-off-by: KashKondaka <[email protected]>

PPL Alerting with Feature Flag #1311

Are you sure you want to change the base?

PPL Alerting with Feature Flag #1311

Uh oh!

Conversation

KashKondaka commented Nov 7, 2025

Description

Issues Resolved

Check List

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amsiglan Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

amsiglan Nov 7, 2025 •

edited

Loading