Add/warn message #105
Open
Add/warn message #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepandhaghighi
requested changes
May 30, 2025
reserver/uploader.py
Outdated
| @@ -135,4 +141,6 @@ def upload(self, package_name, user_parameters=None): | |||
| return False | |||
| else: | |||
| print("Congratulations! You have successfully reserved the PyPI package: ", package_name) | |||
| if show_warning and not self.test_pypi: | |||
There was a problem hiding this comment.
I recommend displaying a warning message for Test PyPI as well, possibly requiring a different URL.
There was a problem hiding this comment.
I thought that this might not be important (test token) but you are right, no matter it is test or main pypi, it should be covered.
done.
CHANGELOG.md
Outdated
| @@ -6,8 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
| ### Added | |||
| - `warning` message regarding PyPI token revoke | |||
There was a problem hiding this comment.
warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#77
What does this implement/fix? Explain your changes.
Any other comments?