Merged
Conversation
bloodearnest
force-pushed
the
fix-telem-naming
branch
2 times, most recently
from
07522f6 to
465dc2b
Compare
rap.backend is designed to be the global filter that excludes all telemetry that is not related to that backend from our dashboards. We had added job.backend, but as not every bit of telemetry is job related (e.g. some controller, all airlock), that's not enough for a sufficiently global filter. This adds rap.backend as a copy of job.backend to the job span metadata helper method, so all job related telemetry has it by default.
Hopefully help keep thing consistent going forwards
bloodearnest
force-pushed
the
fix-telem-naming
branch
from
465dc2b to
d0af2b1
Compare
evansd
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rap.backend to all controller telemetry
We were already adding job.backend for job related telemetry, which is fine.
But the idea was that all telemetry reltated to a particular backened would
have rap.backend attr, which would override the default resource level
rap.backend. This is so we can filter telemetry easily on dashboards.