RemoveRedundantDependencyVersions recipe removes direct dependencies if dependency is pulled in transitively #5409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if dependency is pulled in transitively
shanman190
reviewed
May 10, 2025
rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
Outdated
Show resolved
Hide resolved
Jenson3210
reviewed
May 13, 2025
rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
Show resolved
Hide resolved
Jenson3210
reviewed
May 13, 2025
rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
Outdated
Show resolved
Hide resolved
Jenson3210
reviewed
May 13, 2025
rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
Outdated
Show resolved
Hide resolved
Jenson3210
reviewed
May 13, 2025
rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
Outdated
Show resolved
Hide resolved
shanman190
reviewed
May 17, 2025
There was a problem hiding this comment.
optional: should we also consider moving from Groovy visitors to the more general Java visitors in order to bring Kotlin DSL support to this recipe? There doesn't appear to be any specific functionality used, so it should be a pretty straight forward class swap.
rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
Outdated
Show resolved
Hide resolved
|
The Maven version of this recipe has controls to allow the user to specify when to remove. If we have the same options on the gradle recipe we can group them together into a single remove-redundants in rewrite-java-dependencies |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-gradle/src/test/java/org/openrewrite/gradle/RemoveRedundantDependencyVersionsTest.java
Outdated
Show resolved
Hide resolved
sambsnyd
deleted the
remove-redundant-dependency-versions-removeDirectDependencies
branch
knutwannheden
pushed a commit
that referenced
this pull request
May 23, 2025
…if dependency is pulled in transitively (#5409) * RemoveRedundantDependencyVersions recipe removes direct dependencies if dependency is pulled in transitively * Polish * Can handle several boms * Added sorting to find highest dependency managed version * cleanup * extracted method out of loop * improved name, removed unused option * Added support for kotlin, added support for all dependency management methods. * renamed method * reverted temporary assignment for debug purposes --------- Co-authored-by: Johan Kragt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Redundant direct dependencies are removed as well.
Anything in particular you'd like reviewers to focus on?
Interestingly, the recipe did remove direct dependencies with a lower version number already. This was actually a side effect by removing redundant constraints. I just added an extra check to see if the version
Checklist