DataTableStore
so that RewriteRpc does not need to push ExecutionContext
or DataTable
over the wire.
#5260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
ExecutionContext
should refer toDataTableStore
rather than directly storing rows on itself in memory. By default, Java-only recipe execution can still use anInMemoryDataTableStore
that essentially behaves as it does now.However, this will enable us to inject a different implementation into recipe runs that use
RewriteRpc
so that each process can push rows to a single store without necessarily passing these rows over the wire as control passes between the processes.This will also ultimately help solve large data table downloading in the SaaS.
DataTableStore
has anacceptRows
method on it that can be used byPreconditions
implementations to essentially shut off the flow of rows into the store by recipes being used as preconditions.The implementation of openrewrite/rewrite-maven-plugin#751 would have to change accordingly.