Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There're no references to classes of com.gradle:gradle-enterprise-gradle-plugin in the Gradle module #5143

Closed

Conversation

bmuschko
Copy link
Contributor

@bmuschko bmuschko commented Mar 7, 2025

What's changed?

The dependency on com.gradle:gradle-enterprise-gradle-plugin has been removed from the Gradle module.

What's your motivation?

The Gradle module doesn't use any of the classes brought in by the dependency AFAIKT. We are using type tables here now so the dependency wouldn't be added as a transitive anymore though there's not point in having it's classes aren't used.

For reference, the two recipes that would potentially use the dependency:

Anything in particular you'd like reviewers to focus on?

No

Anyone you would like to review specifically?

No

@bmuschko bmuschko changed the title There're no references to classes in the module There're no references to classes of com.gradle:gradle-enterprise-gradle-plugin in the Gradle module Mar 7, 2025
@knutwannheden
Copy link
Contributor

There is still a reference to the Gradle Enterprise classes in a Groovy script we have for Gradle type attribution support. But the dependency is a compile-only dependency. The important thing is that the gradle-enterprise.jar has been removed from the rewrite-gradle.jar.

The dependency you are removing is used to create the type table, so I think we should leave that in so that we can recreate the type table, when required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants