Reordering Annotations

[steve-aom-elliott]

• Java recipe to reorder annotations #543

Reordering annotations (alphabetically only for now on method declarations alone).

Looking to define boundaries for what should be included in the changes for annotation reordering. As per the linked issue, the starting point would be a default alphabetical ordering of annotations (the ability to pass in what Comparator<J.Annotation> to use will be upcoming). It's been suggested to start with just method declarations and move on from there after, but I'm open to thoughts and suggestions.

What's changed?

• Added a ReorderAnnotations recipe for reordering annotations (default alphabetic) on J.MethodDeclaration
• Added simple tests for the reordering for method declarations (only using the default sorting)

Related issue with additional fixes that should be implemented first

• #5392

Anyone you would like to review specifically?

@timtebeek
@greg-at-moderne

Checklist

• I've added unit tests to cover both positive and negative cases for method declarations
• I've implemented handling of class declarations
• I've implemented handling of field declarations
• I've added unit tests to cover both positive and negative cases for class declarations
• I've added unit tests to cover both positive and negative cases for field declarations
• I've implemented the ability to provide what Comparator<J.Annotation> you would like to use to sort the annotations on a given LST entry point
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 1230-1249
  • lines 1282-1281
  • lines 2311-2310
  • lines 2326-2338
  • lines 2435-2434

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 636-652
  • lines 698-697
  • lines 2311-2310
  • lines 2326-2338
  • lines 2435-2434

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 636-652
  • lines 698-697
  • lines 2311-2310
  • lines 2326-2338
  • lines 2435-2434