Skip to content

Fix misaligned .editorconfig to fix wildcard imports #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented Apr 8, 2025

Fix misaligned .editorconfig to fix wildcard imports.

as seen here we still produce unwanted start imports: https://github.com/openrewrite/rewrite-static-analysis/pull/497/files#r2032495684

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Apr 8, 2025
@Pankraz76 Pankraz76 changed the title Fix format in test Fix misaligned .editorconfig Apr 8, 2025
@Pankraz76 Pankraz76 changed the title Fix misaligned .editorconfig Fix misaligned .editorconfig to fix wildcard imports Apr 8, 2025
}
}
"""
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have 2 spaced indentations mixed with 4. I do not care whats the value, but it should be set and done.

Checkstyle is doing in its test this smaller scope too and google is on this train too. So we might hop on: https://google.github.io/styleguide/javaguide.html#s4.2-block-indentation

@Pankraz76
Copy link
Contributor Author

kindly request your feedback on this @timtebeek @greg-at-moderne

@Pankraz76 Pankraz76 marked this pull request as ready for review April 8, 2025 09:32
@timtebeek
Copy link
Contributor

hi @pankratz76 ; appreciate the help; it's been proving difficult to get to all the reviews lately, and then we tend to prioritize those that fix an issue or add a feature over those that purely improve the code. Appreciate your patience as we work through a backlog of issues, as I know you've contributed quite a few into that last category recently. With those larger restructurings it's also quite a bit of effort to ensure it all functionally works the same, as we can't solely rely on the unit tests that we have, but need to verify these at scale as well.

@Pankraz76
Copy link
Contributor Author

at scale as well

automation is key, as we cannot rely on something we do not measure.
So if we can leverage something like gatling this would help us to get ritt of this issue right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants