-
Notifications
You must be signed in to change notification settings - Fork 71
Fix misaligned .editorconfig
to fix wildcard imports
#498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix misaligned .editorconfig
to fix wildcard imports
#498
Conversation
src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java
Outdated
Show resolved
Hide resolved
.editorconfig
to fix wildcard imports
} | ||
} | ||
""" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have 2 spaced indentations mixed with 4. I do not care whats the value, but it should be set and done.
Checkstyle is doing in its test this smaller scope too and google is on this train too. So we might hop on: https://google.github.io/styleguide/javaguide.html#s4.2-block-indentation
kindly request your feedback on this @timtebeek @greg-at-moderne |
hi @pankratz76 ; appreciate the help; it's been proving difficult to get to all the reviews lately, and then we tend to prioritize those that fix an issue or add a feature over those that purely improve the code. Appreciate your patience as we work through a backlog of issues, as I know you've contributed quite a few into that last category recently. With those larger restructurings it's also quite a bit of effort to ensure it all functionally works the same, as we can't solely rely on the unit tests that we have, but need to verify these at scale as well. |
automation is key, as we cannot rely on something we do not measure. |
Fix misaligned
.editorconfig
to fix wildcard imports.as seen here we still produce unwanted start imports: https://github.com/openrewrite/rewrite-static-analysis/pull/497/files#r2032495684