Skip to content

RemoveRedundantTypeCast should not remove required downcast #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

protocol7
Copy link
Contributor

Adds a failing test case for where RemoveRedundantTypeCast should not remove a downcast that is necessary for chained calls to get matching types.

Adds a failing test case for where RemoveRedundantTypeCast should not
remove a downcast that is necessary for chained calls to get matching
types.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/staticanalysis/RemoveRedundantTypeCastTest.java
    • lines 563-563

@timtebeek timtebeek added bug Something isn't working recipe labels Apr 6, 2025
@timtebeek
Copy link
Contributor

Thanks for the runnable example!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers recipe
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants