Skip to content

Changed start parameters "Demo Model 1" #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sweiland-openrails
Copy link
Contributor

Changed start parameters "Demo Model 1" to fit to the V1.6 "Getting Started" webpage

@sweiland-openrails sweiland-openrails marked this pull request as draft July 11, 2025 10:07
@cjakeman
Copy link
Contributor

Hi Siebren,

Thanks but I don't think this PR is needed.

If you look back to this PR, you will see that the parameters have been removed for Demo Model 1.

This is because they were being over-specified. If you specify the activity, that determines all the lesser parameters such as time of day. These lesser parameters should only be specified for an Explore, not an Activity.

Does that make sense?

Chris

@sweiland-openrails
Copy link
Contributor Author

sweiland-openrails commented Jul 14, 2025

hi Chris,

see my comment at PM https://www.elvastower.com/forums/index.php?app=members&module=messaging&section=view&do=showConversation&topicID=56082:

The Getting Started is based on running the Demo Model 1 in - Explore Mode -. Being the easiest way to get started. After that I let the user switch to the activity. For that modifying the start parameters in routes.json is needed: https://github.com/o...content/pull/19.

But please wait with merging until the Demo Model 1 has been fixed so that I can test. And of course you might not agree with this change.

regards, Siebren

@cjakeman
Copy link
Contributor

Hi Siebren,

But please wait with merging until the Demo Model 1 has been fixed so that I can test. And of course you might not agree with this change.

OK. I see what you are trying to do here and I'm happy to try it out.

I'll get on then with updating Demo Model 1.

Best wishes,

Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants