Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add message 1 decoding to nexrad level2 reader #267

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Feb 6, 2025

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.57%. Comparing base (f5f1f6f) to head (96fd08c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xradar/io/backends/nexrad_level2.py 96.96% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   93.57%   93.57%   -0.01%     
==========================================
  Files          26       26              
  Lines        5042     5073      +31     
==========================================
+ Hits         4718     4747      +29     
- Misses        324      326       +2     
Flag Coverage Δ
notebooktests 79.20% <80.30%> (+0.22%) ⬆️
unittests 93.15% <96.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator Author

Heads-up! This is working nicely. It was almost straightforward to implement (most of the structure was already defined). I'm going to merge tomorrow and let a release out, if no one beats me to it ;-)

@kmuehlbauer kmuehlbauer merged commit fc43e60 into openradar:main Feb 7, 2025
12 checks passed
@kmuehlbauer kmuehlbauer deleted the nexrad-message-1 branch February 7, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

NEXRADLevel2 Reader Error for Older Files
1 participant