Add parser support for "extern port" and "extern frame" statements #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll make a separate PR to update the tests to not require Python 3.7. |
braised-babbage
requested review from
aspcompiler and
braised-babbage
and removed request for
aspcompiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenPulse specifies that ports and frame may declared via "extern port" and "extern frame" statements (see https://openqasm.com/language/openpulse.html#ports and https://openqasm.com/language/openpulse.html#frames).
However OpenQASM only supports extern functions (not identifiers) so both of these statements are currently unsupported and raise parsing errors.
The OpenPulse examples also use "extern port". See https://openqasm.com/language/pulses.html#inline-calibration-blocks and https://openqasm.com/language/pulses.html#inline-calibration-blocks for relevant examples.
This merge request adds support for "extern port" and "extern frame" statements. Its intended to be a minimal parse update to match the current OpenPulse specification.
This issue was reported in openqasm/openqasm#577 and I've also encountered it myself in Zurich Instruments' OpenPulse compiler.