fix: handle edge runtime pages and middleware for turbopack builds #3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
changed the title
pieh
commented
Jul 14, 2025
Comment on lines
+153
to
+158
| parts.push( | ||
| `const middlewareEntryKey = Object.keys(_ENTRIES).find(entryKey => entryKey.startsWith("middleware_${name}"));`, | ||
| // turbopack entries are promises so we await here to get actual entry | ||
| // non-turbopack entries are already resolved, so await does not change anything | ||
| `export default await _ENTRIES[middlewareEntryKey].default;`, | ||
| ) |
There was a problem hiding this comment.
the only real change here is adding await to exported value, but I did very small change to add some context about that in comment
pieh
commented
Jul 14, 2025
| @@ -105,6 +105,7 @@ export const copyNextServerCode = async (ctx: PluginContext): Promise<void> => { | |||
| `server/*`, | |||
| `server/chunks/**/*`, | |||
| `server/edge-chunks/**/*`, | |||
| `server/edge/chunks/**/*`, | |||
There was a problem hiding this comment.
needed for edge runtime pages when building with turbopack
server/edge-chunks seems to contain things like assets and wasm files (?) for middleware for non-turbopack builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #2987
This will attempt to adjust handling to fix:
Previous PR did adjust setup for nodejs pages, but that is not sufficient for full coverage
Documentation
Tests
Expanded turbopack fixture and tests to test edge runtime pages and middleware
Relevant links (GitHub issues, etc.) or a picture of cute animal