Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use join instead of path.join #99

Merged
merged 2 commits into from
Oct 14, 2024
Merged

refactor: use join instead of path.join #99

merged 2 commits into from
Oct 14, 2024

Conversation

james-elicx
Copy link
Collaborator

Context
We're inconsistent with how we use default imports with node:path vs every other import in the codebase.

Changes

  • Pulls the path normalization out into a utility.
  • Replaces the path default import with importing the actual stuff that's used.

Copy link

changeset-bot bot commented Oct 13, 2024

⚠️ No Changeset found

Latest commit: 5e7edde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@james-elicx james-elicx changed the title refactor: utility to normalize file paths refactor: use join instead of path.join Oct 13, 2024
Copy link

pkg-pr-new bot commented Oct 13, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@99

commit: 5e7edde

@james-elicx james-elicx marked this pull request as ready for review October 13, 2024 16:12
@james-elicx james-elicx requested review from vicb and dario-piotrowicz and removed request for vicb October 13, 2024 16:12
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vicb vicb merged commit 081098b into main Oct 14, 2024
7 checks passed
@vicb vicb deleted the james/path-join branch October 14, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants