Commerce

[vicb]

No description provided.

[vicb]

@dario-piotrowicz thanks for fixing the PR.

LGTM with a few comments:

• I wouldn't update the app more than what is needed to run on workers
• I wouldn't test things depending on the shop content that we don't control

[dario-piotrowicz]

@vicb the tweaks I made to the app were actually necessary to get any e2e to work

so I've removed the e2es altogether... let me know what you prefer, we can either keep the e2es but re-add some slight tweaks to the app or have the app without any sort of e2e...

[vicb]

@dario-piotrowicz it's becoming hard to review, could you squash your commits in fewer commits to ease the review.

the tweaks I made to the app were actually necessary to get any e2e to work

I'm not sure to understand the root cause here.
If the CI creates the .dev.vars then it should be able to bring up the app?
But I guess it's not a big deal anyway.

[dario-piotrowicz]

@dario-piotrowicz it's becoming hard to review, could you squash your commits in fewer commits to ease the review.

sure

the tweaks I made to the app were actually necessary to get any e2e to work

I'm not sure to understand the root cause here.
If the CI creates the .dev.vars then it should be able to bring up the app?

I've remove that part, I think that we do not want the e2es to work only when the .dev.vars file is fully populated because this would be problematic for external contributors that would be forced to get a shopify key to get the e2es to work (adding a significant friction point in my opinion)

And the wrangler dev command without all the .dev.vars although works if you view the app with your browser is not getting detected as working properly by playwright (I suspect that playwright is getting some 500s when trying to see if the server is running)

[dario-piotrowicz]

@vicb I've rebased and squashed my commits, please have another look 🙏

[vicb]

Looks good, thanks for making this work!