Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upload playwright reports #303

Merged
merged 5 commits into from
Jan 30, 2025
Merged

ci: upload playwright reports #303

merged 5 commits into from
Jan 30, 2025
+13 −6

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 30, 2025

@dario-piotrowicz or @petebacondarwin: do you have any ideas of what the dev tests are? The only difference seems to be the port? Do we still need them? At least I don't think we should both in CI?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3752e96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb requested a review from dario-piotrowicz January 30, 2025 11:48
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 30, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@303

commit: 3752e96

@vicb vicb requested a review from petebacondarwin January 30, 2025 11:58
dario-piotrowicz
dario-piotrowicz approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

examples/api/e2e/playwright.config.ts Show resolved Hide resolved
@vicb
Copy link
Contributor Author

vicb commented Jan 30, 2025

Thanks for the review @dario-piotrowicz,
We should hopefully see less CI errors.

@vicb vicb merged commit deaf845 into main Jan 30, 2025
7 checks passed
@vicb vicb deleted the palywright-reports branch January 30, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @dario-piotrowicz