-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve separation of source / output paths in config #100
Conversation
|
commit: |
cf272be
to
7b0d08d
Compare
7b0d08d
to
8076b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙂
Especially since you reverted the change @vicb commented about, since that's not an issue here I think the PR shouldn't really be controversial at this point 🙂
But we do have an issue there in the sense the CLI fails to build in skip-build mode if no .next
folder exists. @james-elicx could you open an issue for that so we can keep track of it? 🙂
Context
Source and output paths are currently mixed in the config with no clear distinction
Changes