Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve separation of source / output paths in config #100

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Oct 13, 2024

Context
Source and output paths are currently mixed in the config with no clear distinction

Changes

  • Restructures config types into separate objects for source paths vs output paths vs internal paths.

Copy link

changeset-bot bot commented Oct 13, 2024

⚠️ No Changeset found

Latest commit: 807dd0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 13, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@100

commit: 807dd0a

Base automatically changed from james/path-join to main October 14, 2024 05:54
@james-elicx james-elicx force-pushed the james/refactor-config-slightly branch from cf272be to 7b0d08d Compare October 14, 2024 06:25
@james-elicx james-elicx force-pushed the james/refactor-config-slightly branch from 7b0d08d to 8076b05 Compare October 14, 2024 06:32
@james-elicx james-elicx marked this pull request as ready for review October 14, 2024 06:36
@james-elicx james-elicx changed the title refactor: use source dir to get app path in config refactor: improve separation of source / output paths in config Oct 17, 2024
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

Especially since you reverted the change @vicb commented about, since that's not an issue here I think the PR shouldn't really be controversial at this point 🙂

But we do have an issue there in the sense the CLI fails to build in skip-build mode if no .next folder exists. @james-elicx could you open an issue for that so we can keep track of it? 🙂

@james-elicx james-elicx merged commit 297e147 into main Oct 23, 2024
7 checks passed
@james-elicx james-elicx deleted the james/refactor-config-slightly branch October 23, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants