Skip to content

Add a compileEdge parameter to compileOpenNextConfig #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Mar 24, 2025

The cloudflare adapter will move away from using an internal middleware.

With this change we can still force the compilation of an edge configuration when the middleware is part of the server bundle.

(Longer term we might want to find a better solution to detect this)

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: 629fba6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 24, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@796

commit: 629fba6

Copy link
Contributor

github-actions bot commented Mar 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.22% 2358 / 8992
🔵 Statements 26.22% 2358 / 8992
🔵 Functions 52.71% 126 / 239
🔵 Branches 73.15% 586 / 801
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build.ts 0% 0% 0% 0% 1-83
packages/open-next/src/build/compileConfig.ts 0% 0% 0% 0% 1-122
Generated in workflow #1101 for commit 629fba6 by the Vitest Coverage Report Action

@vicb vicb requested a review from conico974 March 24, 2025 10:02
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I think in the long term, we could look at the wrappers used to determine what we need to do here.

@vicb
Copy link
Contributor Author

vicb commented Mar 24, 2025

I think in the long term, we could look at the wrappers used to determine what we need to do here.

+1, the wrapper should have a way to indicate what they need.

Thanks for the review!

@vicb vicb merged commit c97ced1 into main Mar 24, 2025
3 checks passed
@vicb vicb deleted the vicb/config-edge branch March 24, 2025 10:10
@github-actions github-actions bot mentioned this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants