Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow null to be returned as an incremental cache get result #726

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

Very minor but I think it would be nice if we could return null as the incremental cache get result instead of being forced to return an empty object:
https://github.com/opennextjs/opennextjs-cloudflare/blob/642c3d2e654ef830b7957faecb1cbe26bae469ed/packages/cloudflare/src/api/kvCache.ts#L46

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: e8961ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.28% 1950 / 8028
🔵 Statements 24.28% 1950 / 8028
🔵 Functions 51.61% 112 / 217
🔵 Branches 71.34% 488 / 684
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts 86.06% 82.52% 100% 86.06% 93-94, 152-154, 157-165, 217-228, 250-251, 380-389, 424-432, 466-467
packages/open-next/src/core/routing/cacheInterceptor.ts 88.17% 65.21% 100% 88.17% 31, 42-48, 62-63, 102, 139-140, 145-146, 152-154, 162-163, 215-216
packages/open-next/src/overrides/incrementalCache/multi-tier-ddb-s3.ts 0% 0% 0% 0% 1-143
packages/open-next/src/types/overrides.ts 0% 0% 0% 0%
Generated in workflow #932 for commit e8961ab by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Feb 5, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@726

commit: e8961ab

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just a few minor things that i noticed and that could be improved

@dario-piotrowicz
Copy link
Contributor Author

Thanks a bunch for the review @conico974

I've applied your suggestions please have another quick look and let me know if you're happy with the changes 🙂

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect Thanks

@dario-piotrowicz dario-piotrowicz merged commit b3069dc into main Feb 5, 2025
3 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/allow-incrementalcache-null branch February 5, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants