-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow null
to be returned as an incremental cache get result
#726
Conversation
|
Coverage Report
File Coverage
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Just a few minor things that i noticed and that could be improved
Thanks a bunch for the review @conico974 I've applied your suggestions please have another quick look and let me know if you're happy with the changes 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect Thanks
Very minor but I think it would be nice if we could return
null
as the incremental cacheget
result instead of being forced to return an empty object:https://github.com/opennextjs/opennextjs-cloudflare/blob/642c3d2e654ef830b7957faecb1cbe26bae469ed/packages/cloudflare/src/api/kvCache.ts#L46