fix: remove cf-connecting-ip headers from external override requests
#724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c3863a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dario-piotrowicz
changed the title
cf-connecting-header headers from external override requests
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
…uests this change removes `cf-connecting-header` headers from requests being sent to external urls during rewrites, this allows such overrides, when run inside a Cloudflare worker to rewrite to urls also hosted on Cloudflare
commit: |
dario-piotrowicz
force-pushed
the
dario/fetch-proxy-cf-connecting-ip-fix
branch
from
7c63dee to
f8425c0
Compare
conico974
approved these changes
Feb 4, 2025
|
Does the test pass with this change? |
vicb
changed the title
cf-connecting-header headers from external override requestscf-connecting-ip headers from external override requests
Co-authored-by: conico974 <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change removes
cf-connecting-headerheaders from requests being sent to external urls during rewrites, this allows such overrides, when run inside a Cloudflare worker to rewrite to urls also hosted on CloudflareWith this change the
Rewrite to external imagetest passes when run in the Cloudflare repoOriginal conversation: #723 (review)