Feat: tag cache mode #717
Merged
Feat: tag cache mode #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4eef3a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
commented
Jan 31, 2025
| }; | ||
|
|
||
| export type NextModeTagCache = BaseTagCache & { | ||
| mode: "nextMode"; |
There was a problem hiding this comment.
I really don't like this name but i couldn't find something better. Maybe someone else will find a better idea
vicb
reviewed
Feb 6, 2025
conico974
force-pushed
the
feat/tag-cache-mode
branch
2 times, most recently
from
cabd61e to
66f4581
Compare
conico974
force-pushed
the
feat/tag-cache-mode
branch
from
66f4581 to
6ee3121
Compare
vicb
reviewed
Feb 21, 2025
vicb
approved these changes
Feb 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #706
Everything should be explained in the issue already
One thing we could do that could improve perf in some cases would be to introduce a new optional method in
incrementalCache:getMetadatathat would retrievelastModifiedas well astags. If provided it would allow us to check the tag cache without having to load the cache value (i.e. probably useless for S3 only incremental cache).This should probably be done in another PR