unit tests feedback #35
Conversation
chienleng
left a comment
chienleng
left a comment
There was a problem hiding this comment.
@Phuc-Hong-Tran see comments. I also noticed you are not using eslint or prettier in your code editor. Either run the lint and format before commit or I can setup pre-commit hook to make things easier.
| import getMinInterval from '$lib/utils/Statistic/min-interval'; | ||
| import data from './min-intervals-data.json' assert { type: 'json' }; | ||
|
|
||
| describe("Find smallest interval", () => { |
There was a problem hiding this comment.
structurally it feels like it should be:
Describe Find smallest interval
- test
should return smallest interval without provided StatType (default to history) - test
should return smallest interval between forecasts - test
should return smallest interval between histories
There was a problem hiding this comment.
I meant putting the three tests inside one describe.
Deploying openelectricity with
|
| Latest commit: |
5be80be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8c8a648a.opennem-app.pages.dev |
| Branch Preview URL: | https://32-adding-unit-tests-for-sta.opennem-app.pages.dev |
| import getMinInterval from '$lib/utils/Statistic/min-interval'; | ||
| import data from './min-intervals-data.json' assert { type: 'json' }; | ||
|
|
||
| describe("Find smallest interval", () => { |
There was a problem hiding this comment.
I meant putting the three tests inside one describe.
|
|
||
| const loadFts = ['exports', 'battery_charging', 'pumps']; | ||
|
|
||
| describe("Test ", () => { |
There was a problem hiding this comment.
please describe the test.
There was a problem hiding this comment.
Sorry about that, this one is still in-progress
|
@Phuc-Hong-Tran @chienleng I assume this is addressing #32? Happy to help get this over the line if useful. Let me know. |
|
@chienleng I'll pick up in the next few days and polish up - @Phuc-Hong-Tran just ping a note here if you want to jump back in, if I don't hear anything I'll assume good to proceed. |
|
thanks @jamescrowley. I think there are some updates to the functions since this PR was started so might want to merge from main branch before continuing. |
No description provided.