(refactor):03-4505-Refactor stock operations forms for ease of maintenance #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents for conditional rendering
…ce base operation detail form by making conditional rendering of fields and ensuring autofeeling
…ce to empty state add buton and launching well
…ockOperationItemCell, enhance StockAvailability with error handling and loading states
…mission step component
…uttons in stock operation submission form
…ement in stock operations;seperate concerns on hook
…utility functions for object manipulation
… item form; clean up batch no selector
…nd improve styling; refactor stock operation issue button
…user and batch number selectors
…enhance unit tests for better coverage
…user selectors; improve mock implementations
…ration form utility functions
… operation form with additional tab functionality
…in stock operation forms;Fix undefined bug in operation form submision
jabahum
reviewed
Feb 24, 2025
| @@ -24,15 +24,11 @@ interface BatchNoSelectorProps<T> { | |||
|
|
|||
| const BatchNoSelector = <T,>(props: BatchNoSelectorProps<T>) => { | |||
| const { isLoading, stockItemBatchNos } = useStockItemBatchNos(props.stockItemUuid); | |||
| console.log('stockItemBatchNos', stockItemBatchNos); | |||
There was a problem hiding this comment.
can we remove this console log
There was a problem hiding this comment.
Ok,sure.Its even an older copy which is used to derive the improved one hence it unused and forgot to remove it.all cleaned up now
…ir styles and tests
…ing it with refactored version
jabahum
reviewed
Mar 5, 2025
| @@ -0,0 +1,39 @@ | |||
| import React from 'react'; | |||
|
|
|||
| export const EmptyDataIllustration = ({ width = '64', height = '64' }) => { | |||
There was a problem hiding this comment.
@Omoshlawi i am thiinking we use empty state from framework instead of duplicating efforts
| handleAdd?: () => void; | ||
| message: string; | ||
| }; | ||
| const EmptyState: React.FC<Props> = ({ headerTitle, handleAdd, message }) => { |
| const response: FetchResponse<StockOperationDTO> = await (isEditing ? updateStockOperation : createStockOperation)( | ||
| payload, | ||
| ); | ||
| // const response: FetchResponse<StockOperationDTO> = await (isEditing ? updateStockOperation : createStockOperation)( |
There was a problem hiding this comment.
incase this is not required anymore we can remove it making sure its alternative implementation works as was before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
autofill-responsible.person.mp4
responsible-person-other.mp4
resp0nsible-person-other-edit-mode.mp4
update-operation-add-items.mp4
update-stock-operation-delete-items.mp4
** Component Coupling Issues: **
** State management issues: **
** Unused code segments **
-Inconsistent UI patterns affecting user experience
Screenshots
Related Issue
Other