Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-4301 : A user should be able to see there stock item balances and stock item details in the order basket #254

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jabahum
Copy link
Collaborator

@jabahum jabahum commented Jan 6, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR adds drug/stock item additional information i.e stock prices and stock balances for implementations using the stock management module for inventory management

Screenshots

image

image

Related Issue

https://openmrs.atlassian.net/browse/O3-4301

Other

@jabahum jabahum requested a review from makombe January 6, 2025 07:44
@jabahum jabahum changed the title Feat stock balances O3-4301 : A user should be able to see there stock item balances and stock item details in the order basket Jan 6, 2025
Copy link

github-actions bot commented Jan 7, 2025

Size Change: +10.1 kB (+0.83%)

Total Size: 1.23 MB

ℹ️ View Unchanged
Filename Size Change
dist/172.js 5.48 kB 0 B
dist/18.js 200 kB +62 B (+0.03%)
dist/20.js 1.4 kB 0 B
dist/26.js 24.1 kB 0 B
dist/271.js 4.02 kB 0 B
dist/290.js 5.5 kB 0 B
dist/294.js 2.63 kB 0 B
dist/319.js 4.18 kB 0 B
dist/46.js 3.09 kB 0 B
dist/460.js 4.33 kB 0 B
dist/484.js 3.03 kB 0 B
dist/574.js 3.54 kB 0 B
dist/606.js 3.12 kB 0 B
dist/627.js 1.98 kB 0 B
dist/629.js 6.86 kB 0 B
dist/651.js 157 kB +615 B (+0.39%)
dist/707.js 6.8 kB 0 B
dist/757.js 4.29 kB 0 B
dist/788.js 4.54 kB 0 B
dist/793.js 315 kB 0 B
dist/807.js 4.65 kB 0 B
dist/833.js 4.13 kB 0 B
dist/935.js 42.9 kB 0 B
dist/main.js 401 kB +605 B (+0.15%)
dist/openmrs-esm-stock-management-app.js 3.46 kB 0 B
dist/772.js 5.93 kB +5.93 kB (new file) 🆕
dist/976.js 2.84 kB +2.84 kB (new file) 🆕

compressed-size-action

@jabahum jabahum marked this pull request as ready for review January 7, 2025 09:38
@jabahum jabahum requested a review from donaldkibet January 7, 2025 09:38
@jabahum jabahum self-assigned this Jan 7, 2025
<div className={styles.priceDetailsContainer}>
<span className={styles.priceLabel}>{t('price', 'Price')}:</span>
{purchasePrice !== undefined ? (
<span>{purchasePrice}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jabahum @ojwanganto @makombe is the purchase price of a stock item, the amount we bought the item at or the amount we are selling or charging patients for it. I think for pricing we should use the billing module to indicate the prices.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donaldkibet does the current billing module version provide for stock items being billable items. cc @ODORA0 , @alaboso.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donaldkibet the purchase price is the buying price and is normally used to set the selling price. The selling price rightly sits in the billing module and an item can have different pricing based on the payment methods (this is the current state in Kenya).
@jabahum we still use our own fork of the billing module but it is not very different from the community version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojwanganto how do we make sure your changes in the billing module can fit in here to have this usecase catered for.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we did some enhancement on billing where given the stock item uuid it shows the price

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donaldkibet Can we have the change in the community billing module so that I could use it here. Cc @ojwanganto , @makombe

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jabahum thats fine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donaldkibet any progress on the selling price issue into the billing module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants