-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4026 Add an icon for vitals and biometrics on the left nav #2079
Open
Munyua123
wants to merge
16
commits into
openmrs:main
Choose a base branch
from
Munyua123:vitals-icon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7941c7a
O3-4026 Add an icon for vitals and biometrics on the left nav
Munyua123 cf563c5
Merge branch 'main' into vitals-icon
Munyua123 4ee007c
Update DashboardExtension.tsx
Munyua123 eef52ac
Update dashboardextension.scss
Munyua123 d222915
Update DashboardExtension.tsx
Munyua123 2324f89
Merge branch 'main' into vitals-icon
Munyua123 a8acd6d
Update DashboardExtension.tsx
Munyua123 7cc94cf
Rename dashboardextension.scss to dashboard-extension.scss
Munyua123 57cbf35
Update DashboardExtension.tsx
Munyua123 5be6fcb
Merge branch 'main' into vitals-icon
Munyua123 3769c4f
Update DashboardExtension.tsx
Munyua123 ded2ba9
Merge branch 'main' into vitals-icon
Munyua123 d4cfa4d
Update DashboardExtension.tsx
Munyua123 3779927
Merge branch 'main' into vitals-icon
Munyua123 ea18196
Merge branch 'main' into vitals-icon
Munyua123 640ffd5
Merge branch 'main' into vitals-icon
Munyua123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
packages/esm-patient-common-lib/src/dashboards/dashboard-extension.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
.menu { | ||
display: flex; | ||
align-items: center; | ||
} | ||
|
||
.icon { | ||
margin-right: 0.5rem; | ||
} |
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an object lookup like the following is more preferable. It has less code and better type inference, and it should be straightforward to pop in more icons: