(feat) O3-4064: Print patient information with modified configuration #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -214 kB (-1.42%) Total Size: 14.8 MB
ℹ️ View Unchanged
|
vasharma05
requested review from
denniskigen,
rbuisson,
ibacher,
usamaidrsk and
gracepotma
|
okay @vasharma05 I think I cleaned up my mess... :) The main build is passing now, and I did a follow up commit on this PR fixing the lock file... the tests are running now, fingers crossed, but I will keep an eye on it. |
|
Thanks a lot @mogoodrich!! Really grateful for the same! |
jnsereko
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Thank you @vasharma05. All look good except MSF is interested in the Print Feature being enabled as a Feature flag.
|
I don't think we're yet at a point where the print feature is ready to be automatically enabled. We can maybe discuss a way to make it possible to enable it via configuration, but it's still, IMO, fairly fragile and not yet ready for prime time. |
|
@ibacher what do you mean by "fairly fragile"? Is the code not well-written/tested/stable. |
ibacher
reviewed
Sep 27, 2024
| return printPatientSticker?.header?.logo ? ( | ||
| <img alt="implementation-logo" src={printPatientSticker?.header?.logo} /> | ||
| ) : ( | ||
| <svg data-testid="openmrs-logo" role="img" viewBox="0 0 380 119" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Replace this with an SVG sprite using #omrs-logo-full-mono
There was a problem hiding this comment.
I tried with the above sprite, but it's not rendering in the iframe created by the library when printing the sticker.
There was a problem hiding this comment.
I've left a TODO comment in the logic as a reminder to look into why this isn't working.
|
@rbuisson What I really mean is that this is something like the third re-write of how we configure this component and it isn't clear to me that we are following any requirements gathered from anywhere (this PR, for example, must have a ticket). It's not that I don't trust the code, it's that I don't think what this feature is doing is well-defined enough yet. (Is A4 the right size? Does this support wrist bands? Does this support printing to index-card sizes? Should we be including in the printed space itself data on when it was printed, by whom, and where? Do we need to support multiple configurations of different type of identity cards?) |
denniskigen
reviewed
Sep 27, 2024
packages/esm-patient-banner-app/src/print-identifier-sticker/patient-detail.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-banner-app/src/print-identifier-sticker/patient-detail.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-banner-app/src/print-identifier-sticker/print-identifier-sticker.modal.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-banner-app/src/print-identifier-sticker/print-identifier-sticker.modal.tsx
Show resolved
Hide resolved
| }, | ||
| header: { | ||
| _type: Type.Object, | ||
| _description: 'The header to display on the patient sticker', |
There was a problem hiding this comment.
Suggested change
| _description: 'The header to display on the patient sticker', | |
| _description: 'Configuration properties for the patient sticker headerConfiguration properties for the patient sticker header', |
Maybe this works better?
| return ( | ||
| <div> | ||
| <span> | ||
| <strong className={styles.strong}>{t('patientNameWithSeparator', 'Patient name:')}</strong> |
There was a problem hiding this comment.
Nit: I'm not a big fan of including punctuation marks in the translation string. Different languages have varying punctuation rules, and some may not use certain punctuation marks at all.
There was a problem hiding this comment.
Hey, right, that's why I have added them in the translation string, rather than harcoding this. This gives the user the choice of using their own separator and allows formatting properly for RTL.
Thanks!
.../esm-patient-banner-app/src/print-identifier-sticker/print-identifier-sticker-modal.test.tsx
Outdated
Show resolved
Hide resolved
|
Thank you. Let's see what the feedback and possibly build the case for this first attempt at printing registration card. |
denniskigen
reviewed
Sep 27, 2024
.../esm-patient-banner-app/src/print-identifier-sticker/print-identifier-sticker-modal.test.tsx
Outdated
Show resolved
Hide resolved
denniskigen
reviewed
Oct 3, 2024
denniskigen
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
LGTM. I presume the design will change a fair bit over time as we continue to iterate on the design and the functional requirements. Thanks for working on this, @vasharma05, @usamaidrsk, and thanks for the reviews, @jnsereko, @ibacher.
usamaidrsk
approved these changes
Oct 7, 2024
usamaidrsk
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR works on improving the current implementation of printing the Patient Identifier sticker, with the following additions/ modifications to the existing implementation:
Barcode
The identifier sticker can now house a barcode displaying the patient's Primary identifier Value. Displaying the barcode can be changed via the configuration.
Implementation Logo
The implementer can now decide whether to display the implementation logo on the sticker and if opted, they can also decide to override the default OpenMRS logo with their implementation's logo.
Patient details to be displayed
The implementer can now configure which patient details should be displayed on the sticker. The supported information is shown in the configuration point description.
Patient identifiers
The implementer can configure whether to display all the patient identifiers or a few selected identifiers on the sticker.
Page size
The implementer can configure the sticker page size, which can follow standard pages (A4, A3, etc.) or follow this section for better understanding.
Configuration
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4062
Other