(feat) O3-3921: Change End date to Discontinue date in medications table
#2003
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vijaykv5
changed the title
denniskigen
changed the title
End date to Discontinue date in medications table
denniskigen
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
LGTM, @Vijaykv5, except that we shouldn't update the translation keys and strings for non-en locales by hand. That's taken care of by the transifex integration. I can push commits fixing that if you don't mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR changes text from
End DatetoDiscontinued Datein order to avoid confusion.Screenshots
Current behavior
Desired behaviour
Related Issue
O3-3921
Other