O3-3616: Filter lab results in result tree viewer #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
reviewed
Jul 23, 2024
| if (treeNode.subSets) { | ||
| filteredSubSets = treeNode.subSets | ||
| .map((child) => filterTreeNode(inputValue, child)) | ||
| .filter((child) => child !== null); |
There was a problem hiding this comment.
This works because Boolean is function that coerces the value to a boolean and null gets coerced to `false.
Suggested change
| .filter((child) => child !== null); | |
| .filter(Boolean); |
There was a problem hiding this comment.
@ibacher are you suggesting a different approach?
There was a problem hiding this comment.
Yep... I was suggesting you can replace the .filter(child => child !== null) with the slightly shorter .filter(Boolean)
There was a problem hiding this comment.
Also in the other similar place.
| .filter((child) => child !== null); | ||
| } | ||
|
|
||
| if (filteredSubSets.length > 0) { |
There was a problem hiding this comment.
Why not nest this in the previous if?
|
@reagan-meant I lost track of this one. I think the code looks fine. Are you able to resolve the conflict here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
https://openmrs.atlassian.net/browse/O3-3616
Screenshots
filtering.labs.mov
Related Issue
Other