(fix) O3-3546: Return the specific lab order being modified and not the entire list #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arodidev
commented
Jul 18, 2024
| @@ -67,6 +69,7 @@ function TestTypeSearchResults({ searchTerm, openOrderForm, focusAndClearSearchI | |||
| const { t } = useTranslation(); | |||
| const isTablet = useLayoutType() === 'tablet'; | |||
| const { testTypes, isLoading, error } = useTestTypes(); | |||
| const { orders, setOrders } = useOrderBasket<LabOrderBasketItem>('labs', prepLabOrderPostData); | |||
There was a problem hiding this comment.
Moved the useOrderBasket hook from TestTypeSearchResults to its parent, TestTypeSearch. It didn't seem right to have it run for every iteration of the filteredTestTypes considering it returns the same value for each.
|
My preferred solution for this problem is this, i.e., just take the user directly to the modify form. This is too aggressive because it removes the ability to add another order of a different type while modifying an order (which is a valid use-case for the order basket). |
|
Yes @denniskigen feel free to close this PR, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR introduces adds functionality that filters out test types from the lab order basket when modfying an order and only lists the test type relevant to the order being modified.
Screenshots
Screen.Recording.2024-07-18.at.06.58.40.mov
Related Issue
https://openmrs.atlassian.net/browse/O3-3546
Other