-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-2720: Visit stop date input not working in edit mode #1657
base: main
Are you sure you want to change the base?
Conversation
Size Change: -40.3 kB (0%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
packages/esm-patient-chart-app/src/visit/visit-form/visit-date-time.component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small things.
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-date-time.component.tsx
Outdated
Show resolved
Hide resolved
@ibacher @denniskigen requesting review here. |
There seems to be failure in e2e tests, Makes sense with inline notifications @vasharma05 |
@vasharma05 , is the screenshot in the PR description up to date? |
Hi @vasharma05 , are you just waiting for review? I notice you never replied to @rbuisson 's comment on Slack, nor the one here, and it looks like the screenshot still does not reflect that discussion on Slack. What's going on with this PR? Would be great to wrap this up. |
Hi @brandones! I have resolved the file conflicts and updated the GIF in the PR description. |
This appears to collide with #1657 . I suspect you and @usamaidrsk will want to meet/pair and get these two pieces of work done in coordination with each other. |
There are now conflicts in |
…en multiple conditions
ff000d6
to
bb638d3
Compare
Requirements
Summary
This PR removes passing
minDate
andmaxDate
in the visit stop date and visit start date respectively, since the date fields have multiple conditions related to it. These conditions are present when submitting the form here.Alongside, we display an Inline Notification displaying the error messages.
Screenshots
Screen.Recording.2024-06-23.at.15.44.23.mov
Related Issue
https://issues.openmrs.org/browse/O3-2720
Other
None