Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-2191: Remove the form builder app menu link #151

Merged
merged 1 commit into from
Jun 30, 2023
Merged

(fix) O3-2191: Remove the form builder app menu link #151

merged 1 commit into from
Jun 30, 2023

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Jun 19, 2023 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Since the Form builder link is added on the Admin page, I removed the link from the app menu to avoid duplication.

Screenshots

screencast.2023-06-19.4.PM-43-05.mp4

Related Issue

https://issues.openmrs.org/browse/O3-2191

Other

@denniskigen denniskigen changed the title (fix)O3-2191:Remove the form builder app menu link (fix) O3-2191: Remove the form builder app menu link Jun 20, 2023
hadijahkyampeire
hadijahkyampeire approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwnasambu but let's hold on to merge this until after the Thursday call.

@jwnasambu
Copy link
Contributor Author

@hadijahkyampeire Thanks @denniskigen had already given me the explanation yesterday

@denniskigen denniskigen force-pushed the (Chore)Remove_the_form_builder_app_menu_link branch from 76376e9 to 933a639 Compare June 30, 2023 13:25
@denniskigen denniskigen force-pushed the (Chore)Remove_the_form_builder_app_menu_link branch from 933a639 to 5775b4b Compare June 30, 2023 13:26
@denniskigen denniskigen merged commit f4a6c05 into openmrs:main Jun 30, 2023
@denniskigen denniskigen mentioned this pull request Jul 10, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jexsie Jexsie Jexsie approved these changes

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwnasambu @hadijahkyampeire @Jexsie @denniskigen @jwamalwa