Use recent click (fixes DEV-149)#62
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def setUp(self) -> None: | ||
| runner = CliRunner(mix_stderr=False) | ||
| runner = CliRunner() | ||
| self.result: Result = runner.invoke(cli.main, ["nonexistent.conf"]) |
There was a problem hiding this comment.
With Click ≥8 the default CliRunner() uses mix_stderr=True, so stderr is merged into stdout. The new runner in NonExistentConfigFileTestCase means self.result.stderr (still asserted below) now raises ValueError: stderr not separately captured, causing these tests—and the similar evaporation/hspatial CLI tests—to error before checking the message. Set mix_stderr=False again or adjust the assertions to read from the combined output.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 19 19
Lines 2266 2266
=======================================
Hits 2172 2172
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
No description provided.