Add station search to enhydris_api_client (fixes DEV-129)#59
Merged
aptiko merged 1 commit intoopenmeteo:masterfrom Nov 6, 2025
Merged
Add station search to enhydris_api_client (fixes DEV-129)#59aptiko merged 1 commit intoopenmeteo:masterfrom
aptiko merged 1 commit intoopenmeteo:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for query string filtering to the list_stations() method in the Enhydris API client, allowing users to search for stations matching specific criteria.
- Added optional
query_stringparameter tolist_stations()method - URL-encodes the query string using
quote_plusand appends it as aqparameter to the API endpoint - Updated documentation to reflect the new parameter
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/enhydris_api_client/init.py | Added query_string parameter to list_stations() with URL encoding logic |
| tests/enhydris_api_client/test_station.py | Added test case to verify query string is properly encoded and included in the request |
| docs/enhydris_api_client.rst | Updated method signature and description to document the new parameter |
| CHANGELOG.rst | Added changelog entry for the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 19 19
Lines 2261 2263 +2
=======================================
+ Hits 2167 2169 +2
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.