Skip to content

Add station search to enhydris_api_client (fixes DEV-129)#59

Merged
aptiko merged 1 commit intoopenmeteo:masterfrom
aptiko:dev-129--search-stations
Nov 6, 2025
Merged

Add station search to enhydris_api_client (fixes DEV-129)#59
aptiko merged 1 commit intoopenmeteo:masterfrom
aptiko:dev-129--search-stations

Conversation

@aptiko
Copy link
Copy Markdown
Member

@aptiko aptiko commented Nov 6, 2025

No description provided.

@aptiko aptiko requested a review from Copilot November 6, 2025 11:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for query string filtering to the list_stations() method in the Enhydris API client, allowing users to search for stations matching specific criteria.

  • Added optional query_string parameter to list_stations() method
  • URL-encodes the query string using quote_plus and appends it as a q parameter to the API endpoint
  • Updated documentation to reflect the new parameter

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/enhydris_api_client/init.py Added query_string parameter to list_stations() with URL encoding logic
tests/enhydris_api_client/test_station.py Added test case to verify query string is properly encoded and included in the request
docs/enhydris_api_client.rst Updated method signature and description to document the new parameter
CHANGELOG.rst Added changelog entry for the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.84%. Comparing base (f82fe16) to head (e2bd1b9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files          19       19           
  Lines        2261     2263    +2     
=======================================
+ Hits         2167     2169    +2     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aptiko aptiko merged commit e2bd1b9 into openmeteo:master Nov 6, 2025
12 checks passed
@aptiko aptiko deleted the dev-129--search-stations branch November 6, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants