Skip to content

Produce .msi instead of .exe (fixes DEV-135)#53

Merged
aptiko merged 1 commit intoopenmeteo:masterfrom
aptiko:dev-135--msi
Dec 17, 2025
Merged

Produce .msi instead of .exe (fixes DEV-135)#53
aptiko merged 1 commit intoopenmeteo:masterfrom
aptiko:dev-135--msi

Conversation

@aptiko
Copy link
Copy Markdown
Member

@aptiko aptiko commented Dec 17, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.34%. Comparing base (3baeea6) to head (19ccb17).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files           6        6           
  Lines         826      826           
=======================================
  Hits          738      738           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Windows distribution from a single-file executable to a proper MSI installer, addressing DEV-135. The change eliminates the issue of PyInstaller's single-file mode creating temporary files that waste disk space. The new installer uses WiX Toolset 6.0 to create an MSI package that installs to C:\Program Files\Loggertodb by default.

Key changes:

  • Introduced WiX Toolset 6.0 configuration for MSI generation with license agreement and installation directory selection
  • Modified PyInstaller build to create a directory bundle instead of single-file executable
  • Updated GitHub Actions workflow to build MSI and upload it as release artifact

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pyproject.toml Excludes installer directory from Python package distribution
installer/loggertodb.wixproj Defines WiX project configuration with SDK version, platform, and output naming
installer/Package.wxs Specifies MSI package structure, files to include, and UI components
installer/license.rtf Provides GPL license text in RTF format for installer display
docs/release-notes.rst Documents version 4.3 release with MSI installer change
docs/installation.rst Updates Windows installation instructions to reference MSI file
bin/loggertodb-windows Updates comment to reflect non-single-file PyInstaller usage
.gitignore Adds WiX build output directories to ignore list
.github/workflows/build-exe.yml Installs WiX tooling and modifies build process to generate MSI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build-exe.yml
Comment thread installer/loggertodb.wixproj Outdated
Comment thread .github/workflows/build-exe.yml Outdated
Comment thread .github/workflows/build-exe.yml
Comment thread .github/workflows/build-exe.yml
@aptiko aptiko merged commit 19ccb17 into openmeteo:master Dec 17, 2025
5 checks passed
@aptiko aptiko deleted the dev-135--msi branch December 17, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants