Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #262]Dledger polish project #263

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mxsm
Copy link
Contributor

@mxsm mxsm commented Nov 26, 2022

tracing #262

  • Optimize module structure, add a common module

@mxsm mxsm changed the title Dledger polish project [ISSUE #262]Dledger polish project Nov 27, 2022
Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether it is necessary to extract the common module separately because the core and the common module are used together now

dledger/pom.xml Outdated
@@ -24,13 +24,17 @@
</parent>
<modelVersion>4.0.0</modelVersion>

<artifactId>dledger</artifactId>
<artifactId>dledger-core</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure compatibility, it would be better not to modify the artifactId.

@mxsm
Copy link
Contributor Author

mxsm commented Nov 28, 2022

Whether it is necessary to extract the common module separately because the core and the common module are used together now

command module is noly for CLI , it can't start dledger server. Multi-Raft start with proxy module and normal start with dledger module. so add common module

@mxsm mxsm requested a review from RongtongJin December 1, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants