Skip to content

a11y: update credit link markup for screen-readers #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephDriver wants to merge 2 commits into
base: master
Choose a base branch
from
+27 −15
Open

a11y: update credit link markup for screen-readers #5106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa52894
a11y: #5105 update credit link markup for screen-readers
StephDriver Jan 23, 2026
d4ce7c4
bugfix: credit not displaying on OLH article
StephDriver Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions src/themes/OLH/templates/journal/article.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,22 +478,34 @@ <h2>{% trans "File Checksums" %} (MD5)</h2>
{% endif %}
</div>

{% if journal_settings.general.use_credit and author.credits.exists %}
<div class="section hide-for-small-only">
<h2>{% trans "CRediT Roles" %} <a href="https://www.niso.org/publications/z39104-2022-credit" target="_blank"> <i class="fa fa-info"></i></a></h2>
<ul>
{% for author, credit_records in article.authors_and_credits.items %}
<li>
{{ author.full_name }}:
<span class="credit">
{% for record in credit_records %}
{{ record }}{% if not forloop.last %}, {% endif %}
{% if journal_settings.general.use_credit %}
{% for author_check in article.frozen_authors.all %}
{% if author_check.credits.exists %}
<div class="section hide-for-small-only">
<h2>{% trans "CRediT Roles" %}
<a href="https://www.niso.org/publications/z39104-2022-credit" target="_blank">
<span class="sr-only">{% trans "Read more about Credit." %} </span>
<i aria-hidden="true" class="fa fa-info"></i>
{% include "elements/icons/link_external.html" %}
</a>
</h2>
<ul>
{% for author, credit_records in article.authors_and_credits.items %}
{% if credit_records.exists %}
<li>
{{ author.full_name }}:
<span class="credit">
{% for record in credit_records %}
{{ record }}{% if not forloop.last %}, {% endif %}
{% endfor %}
</span>
</li>
{% endif %}
{% endfor %}
</span>
</li>
{% endfor %}
</ul>
</div>
</ul>
</div>
{% endif %}
{% endfor %}
{% endif %}

<div class="section hide-for-small-only">
Expand Down