fix copy citation button not working on clean

[StephDriver]

In b-4890-loop-a11y-syntax while updating list syntax for loops across the theme, I updated the citation modals too. But on testing Clarity I found this breaks the copy citation function in two ways. First it places lists inside a span, which is invalid HTML and so they end up with an empty span and the lists afterwards. But the copy button is aiming at the span element, so effectively, it copies nothing. Changing out the span for a div doesn't work either, as having a list inside when copy/pasting ends up with bullets being added in when pasting into word.

So the best solution seems to be to revert the original change just for citation_modals.html which was fortunately on a single commit. I have also made the same change to Clarity in #5000.

This PR reverts 55fa11f a11y: #4890 update non-visible list syntax on clean

[ajrbyers]

In b-4890-loop-a11y-syntax while updating list syntax for loops across the theme, I updated the citation modals too. But on testing Clarity I found this breaks the copy citation function in two ways. First it places lists inside a span, which is invalid HTML and so they end up with an empty span and the lists afterwards. But the copy button is aiming at the span element, so effectively, it copies nothing. Changing out the span for a div doesn't work either, as having a list inside when copy/pasting ends up with bullets being added in when pasting into word.

So the best solution seems to be to revert the original change just for citation_modals.html which was fortunately on a single commit. I have also made the same change to Clarity in #5000.

This PR reverts 55fa11f a11y: #4890 update non-visible list syntax on clean

[ajrbyers]

Can I suggest having a hidden plain text version of this that the copy button can target? That way the syntax can remain for screenreaders and the copy/paste will work without inserting bullets?

[StephDriver]

Can I suggest having a hidden plain text version of this that the copy button can target? That way the syntax can remain for screenreaders and the copy/paste will work without inserting bullets?

I am not convinced (yet) because:

1. this will still cause the same copy/paste problem for anyone who manually copies the citation rather than use the copy button.
2. If we include list markup inside a citation, then the screen reader will be announcing that list and offering navigation on it - which interrupts and distracts from the specific word order, punctuation and styling of the citation.

Perhaps we could discuss this further @ajrbyers ?

[StephDriver]

@ajrbyers I think we discussed this and I convinced you - if not could you add here what you want me to do?