Make warning messages more accessible #450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #354.
Fixes #269.
Since this issue was written, we now handle most of the login flow in the back office templates, so messages from Django will only appear in two cases: successful login completed, and successful logout completed.
Successful login originates on a different website (the back office), so we don't have the ability to connect the message's placement on the page with the previous context. But the messages are now placed at the top of the body and with the right role attributes to be announced to AT.
Successful logout originates in the account dropdown of the same website. With the messages at the top of the body, the user will encounter them visually on the same area of the page as their preceding action.
The timeout causing the element to disappear after 5 seconds has been removed.
The Edit on GitHub link has been hidden, since we are no longer actively editing the website.