Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ut TestWorkloadSpreadMutatingPod #1784

Conversation

AiRanthem
Copy link
Member

Ⅰ. Describe what this PR does

make TestWorkloadSpreadMutatingPod pass during a slow execution

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

add a time.Sleep in wherever related

Ⅳ. Special notes for reviews

@AiRanthem AiRanthem force-pushed the fix/ws-ut-TestWorkloadSpreadMutatingPod-241010 branch from 7d73328 to da3b252 Compare October 10, 2024 06:34
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.32%. Comparing base (0d0031a) to head (2cbae33).
Report is 103 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1784      +/-   ##
==========================================
+ Coverage   47.91%   49.32%   +1.40%     
==========================================
  Files         162      191      +29     
  Lines       23491    19616    -3875     
==========================================
- Hits        11256     9675    -1581     
+ Misses      11014     8683    -2331     
- Partials     1221     1258      +37     
Flag Coverage Δ
unittests 49.32% <ø> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: AiRanthem <[email protected]>
@AiRanthem AiRanthem force-pushed the fix/ws-ut-TestWorkloadSpreadMutatingPod-241010 branch from da3b252 to 2cbae33 Compare October 10, 2024 08:32
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@furykerry furykerry merged commit de5c362 into openkruise:master Oct 10, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants