-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chores: use golang standard errors #1518
chores: use golang standard errors #1518
Conversation
Signed-off-by: dongjiang1989 <[email protected]>
Welcome @dongjiang1989! It looks like this is your first PR to openkruise/kruise 🎉 |
Signed-off-by: dongjiang1989 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1518 +/- ##
==========================================
+ Coverage 47.76% 47.78% +0.02%
==========================================
Files 160 160
Lines 23366 23366
==========================================
+ Hits 11161 11166 +5
+ Misses 10992 10985 -7
- Partials 1213 1215 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* use golang standard errors * update test_context.go * add unittest casae * fix unittest * add golangci lint ---------
Ⅰ. Describe what this PR does
https://github.com/pkg/errors has been archived and is no longer maintained.
Use the errors and fmt package from the standard Go library.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Add a
depguard
rule in the golang-cilint configuration to prevent future use ofgithub.com/pkg/errors
.Ⅳ. Special notes for reviews