Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: use golang standard errors #1518

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

dongjiang1989
Copy link
Contributor

Ⅰ. Describe what this PR does

https://github.com/pkg/errors has been archived and is no longer maintained.

Use the errors and fmt package from the standard Go library.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Add a depguard rule in the golang-cilint configuration to prevent future use of github.com/pkg/errors.

Ⅳ. Special notes for reviews

Signed-off-by: dongjiang1989 <[email protected]>
@kruise-bot
Copy link

Welcome @dongjiang1989! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Mar 7, 2024
Signed-off-by: dongjiang1989 <[email protected]>
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 47.78%. Comparing base (04254fb) to head (6c5f150).

Files Patch % Lines
pkg/daemon/criruntime/imageruntime/containerd.go 0.00% 4 Missing ⚠️
pkg/daemon/criruntime/imageruntime/cri.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
+ Coverage   47.76%   47.78%   +0.02%     
==========================================
  Files         160      160              
  Lines       23366    23366              
==========================================
+ Hits        11161    11166       +5     
+ Misses      10992    10985       -7     
- Partials     1213     1215       +2     
Flag Coverage Δ
unittests 47.78% <14.28%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongjiang1989
Copy link
Contributor Author

@FillZpp @zmberg PTAL

Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit c7e1daa into openkruise:master Mar 8, 2024
25 of 27 checks passed
@dongjiang1989 dongjiang1989 deleted the dependency-clean branch March 8, 2024 04:44
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* use golang standard errors


* update test_context.go


* add unittest casae


* fix unittest


* add golangci lint


---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants