8370349: [lworld] Generalize some memory optimizations for strict final fields

[merykitty]

Hi,

Some optimizations in memnode.cpp look at some properties of the pointer such as if it is a field of a value class, or if it is a field of a box class while the required assumption is that the pointer is to a strict final field. This PR cleans that up.

Please leave your reviews, thanks very much.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8370349: [lworld] Generalize some memory optimizations for strict final fields (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1692/head:pull/1692
$ git checkout pull/1692

Update a local copy of the PR:
$ git checkout pull/1692
$ git pull https://git.openjdk.org/valhalla.git pull/1692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1692

View PR using the GUI difftool:
$ git pr show -t 1692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1692.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back qamai! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@merykitty This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370349: [lworld] Generalize some memory optimizations for strict final fields

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the lworld branch:

• 74fc77f: 8366668: [lworld] Follow-up work from the array metadata re-work
• 3af03b2: 8370313: [lworld] compiler/valhalla/inlinetyes/TestUnloadedInlineTypeArray.java fails
• e0aaf29: 8368988: [lworld] Rename classes in valhalla/inlinetypes to be distinct
• ... and 4 more: https://git.openjdk.org/valhalla/compare/be252e2371ced4034ccbcb5c588a465e58c4cc43...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (5a5e4431)

[TobiHartmann]

Nice refactoring, looks good to me!

[merykitty]

Thanks a lot for the review!
/integrate

[openjdk]

Going to push as commit abc1d5b.
Since your change was applied there have been 7 commits pushed to the lworld branch:

• 74fc77f: 8366668: [lworld] Follow-up work from the array metadata re-work
• 3af03b2: 8370313: [lworld] compiler/valhalla/inlinetyes/TestUnloadedInlineTypeArray.java fails
• e0aaf29: 8368988: [lworld] Rename classes in valhalla/inlinetypes to be distinct
• ... and 4 more: https://git.openjdk.org/valhalla/compare/be252e2371ced4034ccbcb5c588a465e58c4cc43...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@merykitty Pushed as commit abc1d5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.